useAccessibilityInfo update #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adkenyon
force-pushed
the
useAccessibilityInfo-update
branch
from
22a94da
to
9d3ba97
Compare
LinusU
reviewed
May 14, 2020
LinusU
reviewed
May 18, 2020
adkenyon
force-pushed
the
useAccessibilityInfo-update
branch
from
f022bbf
to
7842610
Compare
LinusU
reviewed
May 26, 2020
LinusU
reviewed
May 26, 2020
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
LinusU
added
enhancement
|
Thanks @LinusU! anything else you need me to do? |
|
Nope, sorry for the delay, merging and releasing now! Thank you so much for the contribution!! 🙌 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added several other Accessibility features to the
useAccessibilityInfohook.Note:
this does break backwards compatibility with 0.59 which only implements two of the listed accessibility featuresTest Plan
Tested the branch in our RN App
Compatibility
Checklist
README.mdUnclear how to make a snack that points to a forked branch. Would love advice on this if expo snack supports it